Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed TTS Autoplay #17113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed TTS Autoplay #17113

wants to merge 1 commit into from
+2 −1

Conversation

soCallmeAdityaKumar
Copy link
Contributor

@soCallmeAdityaKumar soCallmeAdityaKumar commented Sep 23, 2024 •
edited
Loading

Purpose / Description

Don't play audio automatically" is not respected

Fixes

How Has This Been Tested?

WhatsApp.Video.2024-09-26.at.12.28.27.AM.mp4

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

mikehardy
mikehardy approved these changes Sep 28, 2024
View reviewed changes
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable, thank you

@mikehardy mikehardy added Anki Ecosystem Compatibility Needs Second Approval Has one approval, one more approval to merge labels Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehardy mikehardy mikehardy approved these changes

Assignees
No one assigned
Labels
Anki Ecosystem Compatibility Needs Second Approval Has one approval, one more approval to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: "Deck options > Don't play audio automatically" is not respected
2 participants
@soCallmeAdityaKumar @mikehardy