-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:[BUG] Key Labels Not Displaying in Landscape Mode #17022
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue can be resolved without creating a new layout, which makes the code easier to mantain, so please do that.
Also, this breaks the layout in tablets and screens large enough to properly show the dialog
@BrayanDSO incorporated feedback |
@Arthur-Milchior can u please review this pr |
Please don't ping maintainers in such a hurried manner to get this reviewed. This isn't a high priority issue and we will get it whenever we can. Respect the time and availability of other people, please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dialog broken
Please, ideally use a single commit. You can edit your commit and force push the branch. |
FYI, you'd make the review faster if you could also provide screenshot for vertical, and tablet. So that it's clear it works everywhere. |
Running on the current version of the PR, the dialog seems okay to me. I admit I don't see what's broken. The dialog is smaller. But I must admit that I don't see any problem with not having it take a lot more space. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to clarify what's broken: the dialog looked a certain way before in portrait mode or in big screens like tablets, and this PR breaks that look while it can easily preserve it and fix the issue at the same time. Don't break something to fix another.
@BrayanDSO I tried to preserve the look of the dialog box in portrait mode but it is not possible using signal layout.xml that preserve portrait mode dialog look and also have responsive in landscape mode. |
if have any solution for that .please share it with me |
Hi @BrayanDSO , i fixed the dialog broken issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do not include merge commits
please squash changes to a single commit with descriptive commit title + description
b9e95d9
to
79245e7
Compare
I'll review this again by next week |
Purpose / Description
Key Labels Not Displaying in Landscape Mode
Fixes
Approach
use linear layout
How Has This Been Tested?
Tested on Android Device
UI Screenshots
Checklist
Please, go through these checks before submitting the PR.