Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a /health endpoint #13

Open
icc-garciaju opened this issue Jul 28, 2023 · 2 comments
Open

Add a /health endpoint #13

icc-garciaju opened this issue Jul 28, 2023 · 2 comments

Comments

@icc-garciaju
Copy link

icc-garciaju commented Jul 28, 2023

It could be nice to have a /health enpoint in order to be able to monitor the status of the mediator.

Thanks in avance and thanks for your great work.

@TimoGlastra
Copy link
Member

Agreed, that would be a good addition. should it be exposed on a separate port? You probably don't want this to be exposed to the public, where the endpoint for DIDcomm should be exposed.

This can of course be managed by routing based on path.

Are you willing to open a PR for these changes?

@icc-garciaju
Copy link
Author

Having it on another port will suffice in most cases.

If you deploy it on a kubernetes cluster, and want to monitor it externally, you can use a path on the ingress to redirect it to another port. For kubernetes healthcheck, it won't make any difference.
If you deploy it using docker, you can use a reverse proxy to protect it based on source IP.

But having it on the same port, would be easier to implement as no other listener has to be added.

Anyway, thank you in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants