Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

remove debugger call in spec #5449

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Conversation

aryehbeitz
Copy link

It seems like a mistake. Should be removed I think.

heathkit and others added 20 commits October 14, 2019 23:45
We can't upgrade the version of Selenium without transitioning off the
control flow and breaking a bunch of people. Chrome v75 introduced the
new W3C actions API. Unfortunately, we can't update to support that
API without introducing other breakages, so v74 is the last version
of Chrome that will work with Protractor 5.

You can download a Chrome v74 snapshot from https://commondatastorage.googleapis.com/chromium-browser-snapshots/Linux_x64/638880/chrome-linux.zip

You might also need to pass "--no-sandbox" flag to Chrome
Doing this automatically means we can't pin the version of webdriver
that we use in CI. Instead, we run update in the circle config.
…oxy to 4.5.4

travis_wait is not needed if the sauce connect proxy logs are written to
stdout. This makes debugging proxy problems from the CI logs much
easier. This commit also updates the debugging command to use the
`--doctor` flag.

Other changes include:
1. Upgrade sauce-connect proxy from 4.4.1 to 4.5.4
Optimist has been deprecated over 2 years ago as has a security vulnerability. With this change we use it's successor `yargs`.

Closes: angular#5413
BREAKING CHANGE:

Node.Js version 6 and 8 are no longer supported. Please update to Node.Js 10+

Closes angular#5431
BREAKING CHANGE:
Debugger and explore methods are not compatable with Node 8+. Use `debugger` keyword instead. See: https://goo.gl/MvWqFh
utils.puts is no longer available in Node.JS 12
Protractor debugger and element explorer cannot be used for Node.js 8+ and were removed in version 7.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants