Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

122 pull requests are not being merged! #392

Open
vishwajeetv opened this issue Sep 27, 2014 · 19 comments
Open

122 pull requests are not being merged! #392

vishwajeetv opened this issue Sep 27, 2014 · 19 comments

Comments

@vishwajeetv
Copy link

This project is not actively maintained by collaborators. @IgorMinar Please check the pull requests so that these can be added to the builtwith.angularjs.org website.
Many of these projects look very interesting.

@samdaltonmaag
Copy link

Agreed, these should be reviewed, the page deserves a freshen up.

@ghelton
Copy link

ghelton commented Oct 17, 2014

👍

@vishwajeetv
Copy link
Author

@samdaltonmaag Well, who's gonna do that? Everyone must have been very busy with other work
@Astrism : You seem to be pretty active among angularJS (and open source) community.
Can you communicate with any of the contributors so that you can review those repos and merge them? (or can you delegate this to someone you know?)
Someone actively managing this repo would be great thing for the community.
Don't abandon this. This site is a good attempt towards community building and keeping up with enthusiasm in community.
Thanks. :-)

@ghelton
Copy link

ghelton commented Oct 17, 2014

@vishwajeetv I'm not really connected to any maintainers here but I agree that it would be helpful to find a new maintainer. I'm guessing @IgorMinar or @btford are the only ones with direct access.

It might be a good idea for us to switch to a publicly editable page or maybe someone can build a new site and this one will just fade away. I think this site was most valid when Angular still needed to prove that it was a viable framework, I'm guessing that it's less important in the eyes of the maintainers now. I'd still love to have it as way to browse new angular projects and advertise my own.

@vishwajeetv
Copy link
Author

@Astrism : I don't think abandoning this one is a good idea, considering momentum it has gained. I would try to communicate both of them over email. It may help (at-least they could add someone else as a maintainer)

@caitp
Copy link
Contributor

caitp commented Oct 17, 2014

A few months ago, I spent a significant number of hours reviewing and merging PRs for this repo, it was pretty exhausting --- Repeatedly, sites would be dead, or would require a login to actually see the content, which made for not very fun demos, and generally they were just always bitrotten because there's only one file that really needs to be touched in this repo. But largely it's just that it occupied time which was better spent reviewing PRs and trying to patch bugs, I sort of ran out of steam trying to keep the builtwith repo together.

A publicly editable page is hard, but if there is a solid volunteer who wants to take care of this for a while, it's possible that it could be arranged to give them write access, depending on what owners think of it.

@petebacondarwin
Copy link
Contributor

I think a new site that allows people to submit Angular projects online would be the way forward. How about getting our friend @jimrhoskins who built http://ngmodules.org/modules/ to build a similar site for applications?

@vishwajeetv
Copy link
Author

Hi @caitp thanks for the reply.
We can create a simple rule that if the demo can't be accessed in one step (that is w/o login), it won't be considered for review, and PR would be rejected.
If some volunteers can periodically spend some time on this, it can be maintainable.
I volunteer for this. ( for reviewing PRs containing demos, not publicly editable page - I don't see that idea is practical)

@vishwajeetv
Copy link
Author

@petebacondarwin : Thanks for the reply. Yes, I think a site like ngModules would be great.

@vishwajeetv
Copy link
Author

@btford @IgorMinar @caitp @petebacondarwin @Astrism Please look into this issue and resolve it as soon as possible!
It would greatly help for community building (and convincing managers to use angularjs for production apps! 😄 )

@DigitalSmile
Copy link

So at the end, is it worth adding new pull request or just wait for the new site?

@nodecode
Copy link
Contributor

nodecode commented Jan 7, 2015

@btford @IgorMinar @caitp @petebacondarwin @Astrism I have now added my AngularJS project too, and hope that the pull request will be processed as soon as possible.
#435

@caitp
Copy link
Contributor

caitp commented Jan 7, 2015

but it's so much effortttttt okay fine, I'll do it @nodecode --- later tonight though =)

@ashishdasnurkar
Copy link
Contributor

added our project and sent a pull request too. would be awesome if it is merged. I understand though if the maintainers of this repo are busy :)

@jeantimex
Copy link

Love AngularJS and submitted my project as well, I wish it gets approved, I would be so excited! :)

@shivanykshenoy
Copy link

Same here. Love angularJS and submitted a new PR# 489 for our eCommerce Site. If someone can review, that would be great.

@linslin
Copy link

linslin commented Jun 1, 2015

A half year later, nothing happened. =(

@petebacondarwin
Copy link
Contributor

How about we migrate this application to one where the data is stored in a Firebase DB and that we can more easily administer without having to deal with PRs?

@linslin
Copy link

linslin commented Jun 1, 2015

What about a self administrated list. Add a "report" button on https://builtwith.angularjs.org/ and merge all incoming pull requests automatically. If someone merges a "PR/PORN/ABUSE", he will be fired ;). Self administrated like stackoverflow works pretty fine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests