Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui-router core v6.0.7 does not work with IE version 21H1 #3832

Open
1 of 3 tasks
jcaron opened this issue Aug 11, 2021 · 1 comment
Open
1 of 3 tasks

ui-router core v6.0.7 does not work with IE version 21H1 #3832

jcaron opened this issue Aug 11, 2021 · 1 comment
Labels

Comments

@jcaron
Copy link

jcaron commented Aug 11, 2021

This issue tracker is for Bug Reports and Feature Requests only.

Please direct requests for help to StackOverflow.
See http://bit.ly/UIR-SOF for details.

This is a (check one box):

  • Bug Report
  • Feature Request
  • General Query

My version of UI-Router is: 1.0.29

Bug Report

Current Behavior:

Javascript crashes, testing via try-catch and window alert indicated problem with line 1209 in getSafeConsole. It is trying to check if console.table exists, but throwing an error because console does not exist with the dev tools closed.

Expected Behavior:

No errors occur

Link to Plunker or stackblitz that reproduces the issue:

I'm not sure how to show error without using a modified core.js, as the error only occurs in IE version 21H1 with the dev console closed. I fixed it locally by modifying the line in question to read:

else if (console && (!console.table || !console.error)) {

I do not know if that's the best solution.

@stale
Copy link

stale bot commented Apr 18, 2022

This issue has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs.

This does not mean that the issue is invalid. Valid issues
may be reopened.

Thank you for your contributions.

@stale stale bot added the stale label Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant