Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to select query params, route params out of the store #6

Open
SethDavenport opened this issue Feb 28, 2017 · 2 comments

Comments

@SethDavenport
Copy link
Member

Currently we just stick the raw URL in the store:

screen shot 2017-02-27 at 10 38 27 pm

This is enough to allow time travel over app routes, which is handy. However, consider

Contrast this with how react-router-redux does things:

screen shot 2017-02-27 at 10 43 43 pm

Breaking down the query params into an object; possibly also doing the same thing with route params, would make it much easier to make combination selectors from store and router state using select or @select.

@antl3x
Copy link

antl3x commented Jul 28, 2017

Now with @angular-redux/router is not possible get Query Params or Router Params ? So to get an Query Param or Router Param we should use regex with @select() ?

@Buslowicz
Copy link

Almost a year past the original question was asked, yet nothing has been done. Should we consider the issue as "we don't care", or just nobody has time to do that? Would be handy to at least get a minimal feedback on the status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants