-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack dev server problems 5.0.0-rc.1 #2697
Comments
For # 2, you should be viewing the dev server at http://localhost:8080/. Webpack tells you this when you run the dev server. |
When running I could fix that problem by changing
http://localhost:3000/ works just fine then. |
If you mean the line On the other hand, at the bottom of webpack.make.js |
Ah, I see the disconnect. In 5.0.0 |
Oh sorry that was my bad then. I'm still used to |
I guess i can close this issue then. |
Does your concern # 1 still apply? |
Im not sure. In gulpfile.babal.js
relies on the promise to be resolved. If |
It seems like it's an invalid use of the |
To reiterate,
server.listen(appConfig.clientPort, 'localhost', resolve); |
Correctly! |
Did you want to fix this? |
Yes, i just need to figure out how to do a pull request first, since i've never done a pull request before. |
Awesome, let me know if you need any help :) |
Okay thanks ;) |
fix server.start(...) parameters closes issue angular-fullstack#2697
Fixed server.start(...) parameters to correct function signature closes issue angular-fullstack#2697
Ok i finally created a pull request! |
fix(app): fix webpack dev server issue #2697
Thanks! |
There are two problems with webpack dev server.
generator-angular-fullstack/templates/app/webpack.server.js line 51 needs to be
server.listen(appConfig.clientPort, 'localhost', resolve);
or the resolve callback does not get called (see https://github.com/webpack/docs/wiki/webpack-dev-server#api).
fix(seed): CRSF and token issues #2613 is now causing problems with webpack dev server.
http://localhost:3000/
only returns an errorCannot GET /
due to the fact that webpack dev server expects anindex.html
(see https://github.com/webpack/docs/wiki/webpack-dev-server#content-base).The text was updated successfully, but these errors were encountered: