Wrap test_linux_network_stacksmash_64 in a flaky rerunner (3 runs)
#103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@twizmwazin how do you feel about this temporary solution? |
|
I don't really love it, but having the CI constantly fail is also bad. If this doesn't add a significant amount of time to a CI run its acceptable. |
|
I have no idea how much time this adds... how can I check?
…------- Original Message -------
On Friday, September 8th, 2023 at 4:57 PM, Kevin Phoenix ***@***.***> wrote:
I don't really love it, but having the CI constantly fail is also bad. If this doesn't add a significant amount of time to a CI run its acceptable.
—
Reply to this email directly, [view it on GitHub](#103 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AFCW3IAOX6RYHUQSZKFHCHLXZOWFFANCNFSM6AAAAAA4Q3WPXE).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
I would just look at how long that particular test took to execute and determine if adding 2x that is going to be a big deal overall. If it's under a minute it's probably not the end of the world. The test is failing to import right now though. |
|
Can we use https://github.com/box/flaky instead? |
|
I’m ok with that @ltfish as long as @twizmwazin is ok with a new dependency on this project |
|
Yes that's fine |
twizmwazin
reviewed
Sep 11, 2023
mahaloz
changed the title
test_linux_network_stacksmash_64 in a flaky rerunner (3 runs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test case
test_linux_network_stacksmash_64is constantly failing on runs inside the CI, whether people touch Rex-related components or not. Normally, I'd opt to remove this test altogether, but in lieu of that, I propose to rerun this single test multiple times.