Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging: log file rotation, log exception stack trace and more #10

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

adadurov
Copy link

Improve logging to files:

  • log file rotation
  • log exception stack trace
  • log timestamp with milliseconds
  • log message level (ERROR, TRACE, DEBUG, INFO etc.)
  • prepare to log asynchronously

@xaoseric
Copy link

@adadurov Perhaps take a look at NLog in #19, the file log rotation handling is built into it

https://github.com/NLog/NLog/wiki/File-target

@adadurov
Copy link
Author

@adadurov Perhaps take a look at NLog in #19, the file log rotation handling is built into it

https://github.com/NLog/NLog/wiki/File-target

Thank you, @xaoseric, I know about NLog and other logging solutions. I also understand that the logging implementation here is very basic, looking more like a PoC, so I wanted to contribute my 2 cents to the PoC. But I may be wrong in my understanding or assumptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants