Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Reform instead of Virtus #35

Open
dawidlenkiewicz opened this issue Oct 24, 2016 · 4 comments
Open

Use Reform instead of Virtus #35

dawidlenkiewicz opened this issue Oct 24, 2016 · 4 comments

Comments

@dawidlenkiewicz
Copy link

Hi @andypike !

First of all, great job with Rectify. It looks like a really nice foundation for big Rails projects and basically is a big step in right direction. But using Virtus for form objects is a blocker for me right now - it is not maintained anymore. Did you consider moving to Reform?

@andypike
Copy link
Owner

Thanks for the question @dawidlenkiewicz! I've been asked about this a couple of times and I wanted to wait for a little while to see what happens with Virtus to see of someone picks it up. It looks like that isn't going to happen so I think it would make sense to remove it as a dependency.

From here I need to look into the options, we could move to a different backing gem (so save us some work) or create our own. I'd prefer to use something that is already mature but it will depend how easy it is to integrate as I have a few projects using Rectify and I'd like to maintain the public API if possible.

Sound like you like the idea of Reform, are there other gems that you would consider that we can add to the mix and experiment around with?

Thanks again, would be interested in your thoughts.

Andy

@dawidlenkiewicz
Copy link
Author

Unfortunately, I haven't really used anything besides Virtus and Reform. I agree with you that it would be better to go with some existing and mature solution and it looks like Reform could be that thing. I'm not sure how easy it is to switch it and maintain the public API, but Reform has now an option to use dry-validation, which could be another big win.

@art-solopov
Copy link

art-solopov commented May 1, 2017

Since Virtus was apparently abandoned in favor of dry-struct and dry-types, maybe move it to those solutions?

I'll try to investigate.

@art-solopov
Copy link

I did an attempt to port Rectify to dry-struct and... I'm not quite sure I'm not trying to fit a square peg into a round hole TBH. The API is quite different from Virtus'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants