-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback #3
Comments
Looks like I just assumed the |
Ok the first issue is fixed in the latest commit. Hopefully the second issue resolves itself after you update |
I tried your update. The test wasn't running. I fixed it from the PR linked above.
The test result is in |
Looks like Maven puts things in a different place to Gradle. I'll have to add some logic in so it can find the files. Is this project something I can access or is it private? Would make testing it easier |
Sadly the project is private. 😬 |
Just merged. Thanks for your help :) |
One thing to note, not sure if handled already, but the java_home has to be explicitly set/resolved based on the project's current settings, otherwise it will run maven for example with whichever is the default one in the current env. This might be a problem since you might have one project running or being configured for java11, but have a different java_home configured in your env. On a daily basis, i interact with multiple projects configured with different versions of java, from 8 to 20. The way i had resolved this in the past, for an adhoc build solution in my config, is pulling the current runtime from jdtls, using a request command - The request will return the location of the vm, which is the one for the current project, which can then be set to the java_home in the env table, before running jobstart for mvn. That will only work if the user has configured the vm locations when creating the jdtls configuration - for example. Probably relevant for gradle, but i know maven picks up only java_home, you can't really pass it as command line arg to mvn itself, to tell it which sdk to use. {
"java": {
"configuration": {
"runtimes": [
{
"default": true,
"name": "JavaSE-17",
"path": "/home/linuxbrew/.linuxbrew/Cellar/openjdk@17/17.0.7/libexec"
}
]
}
}
} |
Hi 👋
I saw this project here, and @andy-bell101 was asking for feedback.
I sporadically work on a maven project with JUnit tests, so I try it.
For now, when I try to open the summary I get this error:
And when I try to run a test, I have the following error:
The project use maven.
Thanks for the initiative with this project, I hope this feedback will help
The text was updated successfully, but these errors were encountered: