From 6e3ad6fd7e14d40e64b7e39e03a5b378620e727d Mon Sep 17 00:00:00 2001 From: Andrew Ross Date: Fri, 7 Jun 2024 10:33:46 -0700 Subject: [PATCH] Mute all flaky IndicesRequestCacheIT tests These are very frequent offenders and are causing a lot of pain in CI. Related issues: https://github.com/opensearch-project/OpenSearch/issues/11374 https://github.com/opensearch-project/OpenSearch/issues/12308 https://github.com/opensearch-project/OpenSearch/issues/13540 https://github.com/opensearch-project/OpenSearch/issues/13503 https://github.com/opensearch-project/OpenSearch/issues/13711 https://github.com/opensearch-project/OpenSearch/issues/13949 https://github.com/opensearch-project/OpenSearch/issues/13437 https://github.com/opensearch-project/OpenSearch/issues/13600 Signed-off-by: Andrew Ross --- .../org/opensearch/indices/IndicesRequestCacheIT.java | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/server/src/internalClusterTest/java/org/opensearch/indices/IndicesRequestCacheIT.java b/server/src/internalClusterTest/java/org/opensearch/indices/IndicesRequestCacheIT.java index 766ca2c1189e5..cff0acb2449e5 100644 --- a/server/src/internalClusterTest/java/org/opensearch/indices/IndicesRequestCacheIT.java +++ b/server/src/internalClusterTest/java/org/opensearch/indices/IndicesRequestCacheIT.java @@ -631,6 +631,7 @@ public void testCacheWithFilteredAlias() throws InterruptedException { assertCacheState(client, index, 2, 2); } + @AwaitsFix(bugUrl = "https://github.com/opensearch-project/OpenSearch/issues/11374") public void testProfileDisableCache() throws Exception { Client client = client(); String index = "index"; @@ -673,6 +674,7 @@ public void testProfileDisableCache() throws Exception { } } + @AwaitsFix(bugUrl = "https://github.com/opensearch-project/OpenSearch/issues/12308") public void testCacheWithInvalidation() throws Exception { Client client = client(); String index = "index"; @@ -758,6 +760,7 @@ public void testCacheClearAPIRemovesStaleKeysWhenStalenessThresholdIsLow() throw } // when staleness threshold is lower than staleness, it should clean the stale keys from cache + @AwaitsFix(bugUrl = "https://github.com/opensearch-project/OpenSearch/issues/13540") public void testStaleKeysCleanupWithLowThreshold() throws Exception { int cacheCleanIntervalInMillis = 1; String node = internalCluster().startNode( @@ -804,6 +807,7 @@ public void testStaleKeysCleanupWithLowThreshold() throws Exception { } // when staleness threshold is equal to staleness, it should clean the stale keys from cache + @AwaitsFix(bugUrl = "https://github.com/opensearch-project/OpenSearch/issues/13503") public void testCacheCleanupOnEqualStalenessAndThreshold() throws Exception { int cacheCleanIntervalInMillis = 1; String node = internalCluster().startNode( @@ -982,6 +986,7 @@ public void testStaleKeysRemovalWithoutExplicitThreshold() throws Exception { } // when cache cleaner interval setting is not set, cache cleaner is configured appropriately with the fall-back setting + @AwaitsFix(bugUrl = "https://github.com/opensearch-project/OpenSearch/issues/13711") public void testCacheCleanupWithDefaultSettings() throws Exception { int cacheCleanIntervalInMillis = 1; String node = internalCluster().startNode( @@ -1022,6 +1027,7 @@ public void testCacheCleanupWithDefaultSettings() throws Exception { } // staleness threshold updates flows through to the cache cleaner + @AwaitsFix(bugUrl = "https://github.com/opensearch-project/OpenSearch/issues/13949") public void testDynamicStalenessThresholdUpdate() throws Exception { int cacheCleanIntervalInMillis = 1; String node = internalCluster().startNode( @@ -1169,6 +1175,7 @@ public void testCacheCleanupAfterIndexDeletion() throws Exception { } // when staleness threshold is lower than staleness, it should clean the cache from all indices having stale keys + @AwaitsFix(bugUrl = "https://github.com/opensearch-project/OpenSearch/issues/13437") public void testStaleKeysCleanupWithMultipleIndices() throws Exception { int cacheCleanIntervalInMillis = 10; String node = internalCluster().startNode( @@ -1223,6 +1230,7 @@ public void testStaleKeysCleanupWithMultipleIndices() throws Exception { }, cacheCleanIntervalInMillis * 2, TimeUnit.MILLISECONDS); } + @AwaitsFix(bugUrl = "https://github.com/opensearch-project/OpenSearch/issues/13600") public void testDeleteAndCreateSameIndexShardOnSameNode() throws Exception { String node_1 = internalCluster().startNode(Settings.builder().build()); Client client = client(node_1);