Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove LaunchedEffect workaround #379

Merged
merged 5 commits into from
Oct 14, 2024
Merged

Remove LaunchedEffect workaround #379

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3ab72e8
Remove LaunchedEffect workaround for library bug
jakeroseman Oct 14, 2024
a987fec
Apply Spotless
jakeroseman Oct 14, 2024
163ae12
Changed single var to val
jakeroseman Oct 14, 2024
6838798
Merge branch 'tooltip-example' of https://github.com/android/snippets…
jakeroseman Oct 14, 2024
7b3fc06
Merge branch 'main' into tooltip-example
jakeroseman Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 4 additions & 31 deletions compose/snippets/src/main/java/com/example/compose/snippets/components/Tooltips.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,9 @@ import androidx.compose.material3.Text
import androidx.compose.material3.TextButton
import androidx.compose.material3.TooltipBox
import androidx.compose.material3.TooltipDefaults
import androidx.compose.material3.TooltipState
import androidx.compose.material3.rememberTooltipState
import androidx.compose.runtime.Composable
import androidx.compose.runtime.LaunchedEffect
import androidx.compose.runtime.getValue
import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
import androidx.compose.runtime.setValue
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
Expand Down Expand Up @@ -79,14 +76,13 @@ fun PlainTooltipExample(
modifier: Modifier = Modifier,
plainTooltipText: String = "Add to favorites"
) {
var tooltipState by remember { mutableStateOf(TooltipState()) }
TooltipBox(
modifier = modifier,
positionProvider = TooltipDefaults.rememberPlainTooltipPositionProvider(),
tooltip = {
PlainTooltip { Text(plainTooltipText) }
},
state = tooltipState
state = rememberTooltipState()
) {
IconButton(onClick = { /* Do something... */ }) {
Icon(
Expand All @@ -95,13 +91,6 @@ fun PlainTooltipExample(
)
}
}

// Reset tooltipState after closing the tooltip.
LaunchedEffect(tooltipState.isVisible) {
if (!tooltipState.isVisible) {
tooltipState = TooltipState()
}
}
}

// [END android_compose_components_plaintooltipexample]
Expand All @@ -120,8 +109,6 @@ fun RichTooltipExample(
richTooltipSubheadText: String = "Rich Tooltip",
richTooltipText: String = "Rich tooltips support multiple lines of informational text."
) {
var tooltipState by remember { mutableStateOf(TooltipState(isPersistent = true)) }

TooltipBox(
modifier = modifier,
positionProvider = TooltipDefaults.rememberRichTooltipPositionProvider(),
Expand All @@ -132,7 +119,7 @@ fun RichTooltipExample(
Text(richTooltipText)
}
},
state = tooltipState
state = rememberTooltipState()
) {
IconButton(onClick = { /* Icon button's click event */ }) {
Icon(
Expand All @@ -141,13 +128,6 @@ fun RichTooltipExample(
)
}
}

// Reset tooltipState after closing the tooltip.
LaunchedEffect(tooltipState.isVisible) {
if (!tooltipState.isVisible) {
tooltipState = TooltipState(isPersistent = true)
}
}
}
// [END android_compose_components_richtooltipexample]

Expand All @@ -166,7 +146,7 @@ fun AdvancedRichTooltipExample(
richTooltipText: String = "Rich tooltips support multiple lines of informational text.",
richTooltipActionText: String = "Dismiss"
) {
var tooltipState by remember { mutableStateOf(TooltipState(isPersistent = true)) }
val tooltipState = rememberTooltipState()

TooltipBox(
modifier = modifier,
Expand Down Expand Up @@ -195,13 +175,6 @@ fun AdvancedRichTooltipExample(
)
}
}

// Reset tooltipState after closing the tooltip.
LaunchedEffect(tooltipState.isVisible) {
if (!tooltipState.isVisible) {
tooltipState = TooltipState(isPersistent = true)
}
}
}
// [END android_compose_components_advancedrichtooltipexample]

Expand Down