Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing dispatcher from Bitmap writing #149

Closed
wants to merge 7 commits into from
Closed

Removing dispatcher from Bitmap writing #149

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
10b103f
Removing dispatcher from Bitmap writing, to fix crash when picture is…
riggaroo Sep 11, 2023
99055d8
Apply Spotless
riggaroo Sep 11, 2023
f5ad02c
Put back commented out snippet.
riggaroo Sep 11, 2023
7750cfb
Put back commented out snippet.
riggaroo Sep 11, 2023
e15fa61
Put back commented out snippet.
riggaroo Sep 11, 2023
df8e783
Put back commented out snippet.
riggaroo Sep 11, 2023
6188144
Apply Spotless
riggaroo Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .../snippets/src/main/java/com/example/compose/snippets/graphics/AdvancedGraphicsSnippets.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import android.content.Context
import android.content.Intent
import android.content.Intent.createChooser
import android.graphics.Bitmap
import android.graphics.Canvas
import android.graphics.Picture
import android.media.MediaScannerConnection
import android.net.Uri
Expand All @@ -45,8 +44,10 @@ import androidx.compose.material3.SnackbarHostState
import androidx.compose.material3.SnackbarResult
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.runtime.getValue
import androidx.compose.runtime.remember
import androidx.compose.runtime.rememberCoroutineScope
import androidx.compose.runtime.setValue
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.draw.drawWithCache
Expand All @@ -67,7 +68,6 @@ import com.google.accompanist.permissions.ExperimentalPermissionsApi
import com.google.accompanist.permissions.rememberMultiplePermissionsState
import java.io.File
import kotlin.coroutines.resume
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.launch
import kotlinx.coroutines.suspendCancellableCoroutine

Expand Down Expand Up @@ -108,7 +108,7 @@ fun BitmapFromComposableSnippet() {
// and shares it with the default share sheet.
fun shareBitmapFromComposable() {
if (writeStorageAccessState.allPermissionsGranted) {
coroutineScope.launch(Dispatchers.IO) {
coroutineScope.launch {
val bitmap = createBitmapFromPicture(picture)
val uri = bitmap.saveToDisk(context)
shareBitmap(context, uri)
Expand Down