Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up on baseline profile generation and benchmarking via FTL #292

Merged
merged 5 commits into from
Sep 11, 2024
Merged

Follow up on baseline profile generation and benchmarking via FTL #292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4338753
Switch to lynx api 33 for baseline profile generation on FTL
keyboardsurfer Sep 11, 2024
e99515c
Separate tasks for benchmark and BP generation on FTL
keyboardsurfer Sep 11, 2024
17f9fa3
Trigger builds on all PR
keyboardsurfer Sep 11, 2024
68461ff
Move BP generation and FTL runs to workflow_dispatch
keyboardsurfer Sep 11, 2024
38164bb
Upgrade deprecated actions
keyboardsurfer Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions .github/workflows/firebase_test_lab.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,15 +70,29 @@ jobs:
- name: Install Cloud SDK Beta components
run: gcloud components install beta

- name: Run Macro Benchmarks
- name: Run Benchmarks
run: |
gcloud beta firebase test android run \
--type instrumentation \
--app ${{ github.workspace }}/MacrobenchmarkSample/app/build/outputs/apk/benchmarkRelease/app-benchmarkRelease.apk \
--test ${{ github.workspace }}/MacrobenchmarkSample/macrobenchmark/build/outputs/apk/benchmarkRelease/macrobenchmark-benchmarkRelease.apk \
--device model=redfin,version=30,locale=en,orientation=portrait \
--device model=lynx,version=33,locale=en,orientation=portrait \
--directories-to-pull /sdcard/Download \
--results-bucket gs://macrobenchmark-results \
--environment-variables clearPackageData=true,additionalTestOutputDir=/sdcard/Download,no-isolated-storage=true,androidx.benchmark.enabledRules=Macrobenchmark \
--num-uniform-shards 3 \
--num-uniform-shards 6 \
--timeout 30m

- name: Generate Baseline Profiles
run: |
gcloud beta firebase test android run \
--type instrumentation \
--app ${{ github.workspace }}/MacrobenchmarkSample/app/build/outputs/apk/benchmarkRelease/app-benchmarkRelease.apk \
--test ${{ github.workspace }}/MacrobenchmarkSample/macrobenchmark/build/outputs/apk/benchmarkRelease/macrobenchmark-benchmarkRelease.apk \
--device model=lynx,version=33,locale=en,orientation=portrait \
--directories-to-pull /sdcard/Download \
--results-bucket gs://macrobenchmark-results \
--environment-variables clearPackageData=true,additionalTestOutputDir=/sdcard/Download,no-isolated-storage=true,androidx.benchmark.enabledRules=BaselineProfile \
--num-uniform-shards 2 \
--timeout 30m

8 changes: 3 additions & 5 deletions .github/workflows/macrobenchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,8 @@ name: Builds Macrobenchmarks

on:
pull_request:
types: [opened, synchronize, reopened, 'labeled']
push:
branches: [ macrobenchmark, main ]
workflow_dispatch:

jobs:
# This job checks for any file changed within MacrobenchmarkSample/ folder
Expand All @@ -21,8 +19,8 @@ jobs:
macrobenchmark: ${{ steps.filter.outputs.macrobenchmark }}
steps:
- name: Checkout
uses: actions/checkout@v3
- uses: dorny/paths-filter@v2
uses: actions/checkout@v4
- uses: dorny/paths-filter@v3
id: filter
with:
filters: |
Expand All @@ -39,7 +37,7 @@ jobs:
working-directory: ./MacrobenchmarkSample
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup JDK
id: setup-java
Expand Down