Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import a subset of libbase, build an AAR. #1062

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

DanAlbert
Copy link
Member

It's still quite a lot for just CHECK, LOG, and
DISALLOW_COPY_AND_ASSIGN. The strings stuff is only needed because r26 is too old to have the stdlib string split/starts_with/etc. Maybe I'll end up wanting more later and this is a worthwhile start?

@DanAlbert DanAlbert requested a review from enh-google May 15, 2024 22:34
@DanAlbert DanAlbert marked this pull request as ready for review June 11, 2024 20:12
It's still quite a lot for just CHECK, LOG, and
DISALLOW_COPY_AND_ASSIGN. The strings stuff is only needed because r26
is too old to have the stdlib string split/starts_with/etc. Maybe I'll
end up wanting more later and this is a worthwhile start?
@DanAlbert
Copy link
Member Author

I was able to excise all the stuff I wasn't using, and have made pretty extensive use of this in two draft samples I have, so either this or #1061 ought to be merged. The alternative "write your own" at this point wouldn't be much smaller than this is, but would be worse.

Copy link
Contributor

@enh-google enh-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems less unmanageable than the alternative...

@DanAlbert
Copy link
Member Author

this seems less unmanageable than the alternative...

Both this and absl seem about as easy to maintain to me, but actually a better reason to go this route than the absl route: I need this in libraries. The lack of ABI stability wouldn't matter within the samples repo, but I wouldn't want to accidentally mislead someone into thinking it's safe for library use.

@DanAlbert DanAlbert mentioned this pull request Jun 11, 2024
@DanAlbert DanAlbert enabled auto-merge (rebase) June 11, 2024 20:48
@enh-google
Copy link
Contributor

this seems less unmanageable than the alternative...

Both this and absl seem about as easy to maintain to me, but actually a better reason to go this route than the absl route: I need this in libraries. The lack of ABI stability wouldn't matter within the samples repo, but I wouldn't want to accidentally mislead someone into thinking it's safe for library use.

well, that's part of what i mean --- not wanting to be on the hook for absl updates (and breaking source/abi compatibility if you do).

@DanAlbert DanAlbert merged commit 7c60318 into android:main Jun 11, 2024
2 checks passed
@DanAlbert DanAlbert deleted the base branch June 12, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants