textured-teapot: remove dead code #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whoever wrote this wrote some general purpose texture and renderer classes... which they then copy pasted into each sample. This sample only ever uses a cubemap texture, so delete the other paths and remove the error handling code for a thing that will never happen. The original intent was good, but it's pointless when the three teapots samples (classic, textured, and image-decoder) are three samples that don't share this "common" code. I suspect I'll merge the three at some point, but I don't really like how this particular interface was shaped anyway, so I'll probably rewrite that when I do.
enh-google
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whoever wrote this wrote some general purpose texture and renderer classes... which they then copy pasted into each sample. This sample only ever uses a cubemap texture, so delete the other paths and remove the error handling code for a thing that will never happen.
The original intent was good, but it's pointless when the three teapots samples (classic, textured, and image-decoder) are three samples that don't share this "common" code. I suspect I'll merge the three at some point, but I don't really like how this particular interface was shaped anyway, so I'll probably rewrite that when I do.