Fix the build workflow to actually run on push. #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`[ main develop ]` is not a list of "main" and "develop", it's a list of "main develop". There is no branch named "main develop". This has been wrong since it was originally checked in a few years ago, so checks just have not been running on push. The branch filtering is totally unnecessary. Just remove it. This, it turns out, is the real reason that the badge shows "no status". It's right. This build has never run, so there is no status yet.
enh-google
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ main develop ]is not a list of "main" and "develop", it's a list of "main develop". There is no branch named "main develop". This has been wrong since it was originally checked in a few years ago, so checks just have not been running on push.The branch filtering is totally unnecessary. Just remove it.
This, it turns out, is the real reason that the badge shows "no status". It's right. This build has never run, so there is no status yet.