Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate a kotlin sample to the convention plugin. #1034

Merged
merged 2 commits into from
May 9, 2024
Merged

Migrate a kotlin sample to the convention plugin. #1034

merged 2 commits into from
May 9, 2024

Commits on May 9, 2024

  1. Move Java/Kotlin compat to the convention plugin. 

    This was apparently only ever in the gradle scripts for projects that
used Kotlin. I don't know if it's necessary for Java projects, but it's
likely not harmful? For Kotlin projects these versions all need to
match.

It's actually possible for us to bump this to Java 11, by the look of
things (see the Now In Android link below). For now I'm keeping things
the way they are.

https://github.com/android/nowinandroid/blob/7f2ce57c67c68aa921de9231525a4a47ef431fe8/build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/KotlinAndroid.kt#L63
    @DanAlbert
    DanAlbert committed May 9, 2024
    Configuration menu
    Copy the full SHA
    b6f9e17 View commit details
    Browse the repository at this point in the history

  2. Migrate exceptions to convention plugin.

    @DanAlbert
    DanAlbert committed May 9, 2024
    Configuration menu
    Copy the full SHA
    c0727d8 View commit details
    Browse the repository at this point in the history