Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull to refresh doesn't work when there are no tasks #934

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Pull to refresh doesn't work when there are no tasks #934

wants to merge 10 commits into from

Conversation

AnirudhPudari
Copy link

@AnirudhPudari AnirudhPudari commented Mar 27, 2023 •
edited
Loading

Why these changes are required ?

Issue link

  • Currently on the task list screen when the content is empty or no tasks, pull to refresh doesn't work(it is not shown at all after you swipe down vertically)
  • Reason is the empty container shown doesn't contain pull to refresh
  • Exisiting SwipeRefresh is deprecated

What changes are addressed ?

  • Addressed the issue of showing a pull to refresh spinner both when the content is empty and not empty
  • Migrated SwipeRefresh to PullRefreshIndicator as suggested
todo_test.webm

@AnirudhPudari AnirudhPudari mentioned this pull request Mar 27, 2023
Open
@dturner
Copy link
Collaborator

dturner commented Jun 5, 2023

Please fix the spotless formatting.

@AnirudhPudari
Copy link
Author

AnirudhPudari commented Jun 23, 2023 •
edited
Loading

Please fix the spotless formatting.

@dturner Hi, I have addressed the issue, Please review PR. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AnirudhPudari @dturner @Anirudh-discovery