From 376578ac364321e91a9dc03adc60eb5558c06bcb Mon Sep 17 00:00:00 2001 From: Andrew Herrington Date: Fri, 7 Jan 2022 21:16:03 -0600 Subject: [PATCH] Exclude none values when creating and updating --- src/healthchecks_io/client/async_client.py | 5 +++-- src/healthchecks_io/client/sync_client.py | 7 +++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/healthchecks_io/client/async_client.py b/src/healthchecks_io/client/async_client.py index 40d42ba1..3a18ad69 100644 --- a/src/healthchecks_io/client/async_client.py +++ b/src/healthchecks_io/client/async_client.py @@ -98,7 +98,7 @@ async def create_check(self, new_check: CheckCreate) -> Check: """ request_url = self._get_api_request_url("checks/") response = self.check_response( - await self._client.post(request_url, json=new_check.dict()) + await self._client.post(request_url, json=new_check.dict(exclude_none=True)) ) return Check.from_api_result(response.json()) @@ -118,7 +118,8 @@ async def update_check(self, uuid: str, update_check: CheckCreate) -> Check: request_url = self._get_api_request_url(f"checks/{uuid}") response = self.check_response( await self._client.post( - request_url, json=update_check.dict(exclude_unset=True) + request_url, + json=update_check.dict(exclude_unset=True, exclude_none=True), ) ) return Check.from_api_result(response.json()) diff --git a/src/healthchecks_io/client/sync_client.py b/src/healthchecks_io/client/sync_client.py index 8ee159bf..bd09d920 100644 --- a/src/healthchecks_io/client/sync_client.py +++ b/src/healthchecks_io/client/sync_client.py @@ -138,7 +138,7 @@ def create_check(self, new_check: CheckCreate) -> Check: """ request_url = self._get_api_request_url("checks/") response = self.check_response( - self._client.post(request_url, json=new_check.dict()) + self._client.post(request_url, json=new_check.dict(exclude_none=True)) ) return Check.from_api_result(response.json()) @@ -163,7 +163,10 @@ def update_check(self, uuid: str, update_check: CheckCreate) -> Check: """ request_url = self._get_api_request_url(f"checks/{uuid}") response = self.check_response( - self._client.post(request_url, json=update_check.dict(exclude_unset=True)) + self._client.post( + request_url, + json=update_check.dict(exclude_unset=True, exclude_none=True), + ) ) return Check.from_api_result(response.json())