Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples should be using sizes and srcset #55

Open
yoavweiss opened this issue Jul 26, 2014 · 0 comments
Open

Examples should be using sizes and srcset #55

yoavweiss opened this issue Jul 26, 2014 · 0 comments
Labels

Comments

@yoavweiss
Copy link

Awesome grunt task! :)
One nit though...
Seems like the example on http://www.andismith.com/grunt-responsive-images/ (as well as the copy) is using the full <picture> syntax, where they actually shouldn't.

Since AFAICT this grunt task does not involve art-direction (e.g. no cropping, proportion change, etc), the examples would be significantly better off showing the <img sizes srcset> syntax, which is the best fit for the use-case tackled by this task.

So the example syntax should be:
<img sizes="(min-width: 820px) 800px, (min-width: 640px) 640px, 320px" srcset="wedding-small.jpg 320w, wedding-medium.jpg 640w, wedding-large.jpg 800w">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants