Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate debug functionality #177

Open
johanneskonst opened this issue Dec 22, 2022 · 3 comments
Open

consolidate debug functionality #177

johanneskonst opened this issue Dec 22, 2022 · 3 comments
Assignees
Labels
enhancement Enhancements and improvements, nice to haves for a next release but never mandatory. feedback-wanted Looking for feedback on the issue at hand. Opinions please, constructive ones preferred.
Milestone

Comments

@johanneskonst
Copy link
Collaborator

My plan is to keep only the $config['debug'] setting (so remove the $config['httpclientlog'] one),
move all debug output away from the browser's rendering and into the LOG_FILE (error.log),
and maybe log all stuff fetched from remotes into it's own folder (one file per request).
After that I can put some more effort into fixing #144
Would love to hear your opinions @copperhead57 @kec2 (and others who might find this usefull)

@johanneskonst johanneskonst added enhancement Enhancements and improvements, nice to haves for a next release but never mandatory. feedback-wanted Looking for feedback on the issue at hand. Opinions please, constructive ones preferred. labels Dec 22, 2022
@johanneskonst johanneskonst added this to the 4.2 milestone Dec 22, 2022
@johanneskonst johanneskonst self-assigned this Dec 22, 2022
@kec2
Copy link
Contributor

kec2 commented Dec 22, 2022

I'm thing that consolidating the two settings is fine.
I think that separate log files for SQL, HTTPClient, Frontend and Application.
I would change the setting to a Log level, in stead of On/Off and I would introduce a logging-framework.
One file per request is better then one file i total because of file size if you want to log Header + Data.
That's my thoughts.

@johanneskonst
Copy link
Collaborator Author

Thanks, good points, I'll have a go on this...
Logging framework might be nice in some big future release, but an off/on/verbose setting could be usefull indeed...
http bit is basically two parts: remarks from the executing code and the stuff that's fetched from somewhere, the former would be right at home in an error.log but the latter should indeed be separate files, I have a POC somewhere i can use for that...

@copperhead57
Copy link
Collaborator

FYI only
while testing my move to php7.4, with debug on.
when in imdb online and requesting a series episode list (eg - https://www.imdb.com/title/tt0898266/episodes/?ref_=tt_ov_epl ) the links are not rendered correctly.
have trace this to sending the $note field back into the html from function _replace_enclosed_tag_traced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancements and improvements, nice to haves for a next release but never mandatory. feedback-wanted Looking for feedback on the issue at hand. Opinions please, constructive ones preferred.
Projects
None yet
Development

No branches or pull requests

3 participants