Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable cargo-auditable-binary-cataloger for files/directories #3376

Conversation

ariel-miculas
Copy link
Contributor

Especially when scanning a single binary file, the cargo-auditable-binary-cataloger should run and report the rust binary's dependencies:

scan --select-catalogers rust <binary_file>

This is in line with other binary catalogers, such as the go-module-binary-cataloger.

Description

Please include a summary of the changes along with any relevant motivation and context,
or link to an issue where this is explained.

  • Fixes #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (please discuss with the team first; Syft is 1.0 software and we won't accept breaking changes without going to 2.0)
  • Documentation (updates the documentation)
  • Chore (improve the developer experience, fix a test flake, etc, without changing the visible behavior of Syft)
  • Performance (make Syft run faster or use less memory, without changing visible behavior much)

Checklist:

  • I have added unit tests that cover changed behavior
  • I have tested my code in common scenarios and confirmed there are no regressions
  • I have added comments to my code, particularly in hard-to-understand sections

Especially when scanning a single binary file, the
cargo-auditable-binary-cataloger should run and report the rust binary's
dependencies:

```
scan --select-catalogers rust <binary_file>
```

This is in line with other binary catalogers, such as the
go-module-binary-cataloger.

Signed-off-by: Ariel Miculas-Trif <[email protected]>
@wagoodman wagoodman enabled auto-merge (squash) October 23, 2024 14:46
@wagoodman wagoodman added the enhancement New feature or request label Oct 23, 2024
@wagoodman wagoodman merged commit 06d300e into anchore:main Oct 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants