Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ad_pulsar.c assumes all differential ADC channels are bipolar #2313

Open
dlech opened this issue Oct 30, 2023 · 0 comments
Open

ad_pulsar.c assumes all differential ADC channels are bipolar #2313

dlech opened this issue Oct 30, 2023 · 0 comments

Comments

@dlech
Copy link
Collaborator

dlech commented Oct 30, 2023

Currently, the ad_pulsar.c driver assumes that all differential channels are bipolar and sets the IIO scan info as signed.

adc->channels[chan_index].scan_type.sign = 's';

However, half of the single-channel chips are pseudo-differential and use unsigned data, not signed.

On the multi-channel chips, bipolar or not is a programmable feature and therefore determined by the device tree description of how the channels are configured, but this should not be part of the device tree bindings for single channel chips since they are not configurable.

This is one of the differences that lead me to suggest #2312 as fixing this would be much more straightforward if we didn't have to account for both types of chips (configurable and not configurable) in the same driver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant