Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rebound interface to Rebound release version 4.0.1 #1019

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rieder
Copy link
Member

@rieder rieder commented Dec 11, 2023

The Rebound version currently in AMUSE is quite old - this updates it to the latest release.
The current tests for the rebound interface still work, but should probably be extended.

@rieder rieder requested a review from a team as a code owner December 11, 2023 20:10
LourensVeen
LourensVeen previously approved these changes Dec 12, 2023
Copy link
Collaborator

@LourensVeen LourensVeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice!

@rieder
Copy link
Member Author

rieder commented Dec 12, 2023

It needs more extensive testing. Some features seem to work but on closer inspection require some settings to be changed, not all of which are available through the interface.

@LourensVeen
Copy link
Collaborator

Hm, so I was early. Should there be some kind of norm for this? When is a code integrated well enough that the PR adding it can be merged? That would then set some standards for reviews. All assuming that we're rich enough to be able to afford these kinds of things of course...

@rieder
Copy link
Member Author

rieder commented Dec 12, 2023

I think in principle it can be merged (since it passes all current tests).

However, since the new version of Rebound adds features, these need to be tested as well.
So ideally we want some covering check as well, to make sure the tests don't become meaningless.

@LourensVeen
Copy link
Collaborator

That makes sense.

@rieder
Copy link
Member Author

rieder commented Dec 14, 2023

Rebound should probably have a second worker built - one with, and one without OpenMP support.
For the whfast integrator (which is in turn used by some other integrators), behaviour is different depending on whether OpenMP is used.
In the OpenMP case, it needs a different coordinate system (which is not available through the AMUSE interface yet, and I need to check whether it would make sense to have this available at all).

Copy link

stale bot commented Feb 13, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issues that have been around for a while without updates label Feb 13, 2024
@rieder rieder added keep-open and removed stale Issues that have been around for a while without updates labels Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants