Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify AmpMustache API #894

Open
wants to merge 2 commits into
base: ampstart-2.0
Choose a base branch
from
Open

Simplify AmpMustache API #894

wants to merge 2 commits into from

Conversation

sebastianbenz
Copy link
Collaborator

  • Remove mustache directive abstraction (Section, ...) to keep the API
    simple
  • Simplify server-side template rendering
<div data-amp-bind-hidden='context != undefined'>
  {AmpMustache.render(template, initialItems)}
</div>

@sebastianbenz
Simplify AmpMustache API
8998871 
* Remove mustache directive abstraction (Section, ...) to keep the API
simple
* Simplify server-side template rendering

```
<div data-amp-bind-hidden='context != undefined'>
  {AmpMustache.render(template, initialItems)}
</div>
```
@sebastianbenz
Further improvements:
392ce04 
* fix context indirection
* update readme
@CLAassistant
Copy link

CLAassistant commented Oct 8, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alankent alankent Awaiting requested review from alankent

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastianbenz @CLAassistant