Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Eager Logging to Lazy Logging #74

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pixeeai
Copy link

@pixeeai pixeeai commented Mar 29, 2024

Issue #, if available: N/A

Description of changes:
This codemod converts "eager" logging into "lazy" logging, which is preferred for performance efficiency and resource optimization.
Lazy logging defers the actual construction and formatting of log messages until it's confirmed that the message will be logged based on the current log level, thereby avoiding unnecessary computation for messages that will not be logged.

Our changes look something like this:

import logging
e = "Some error"
- logging.error("Error occurred: %s" % e)
- logging.error("Error occurred: " + e)
+ logging.error("Error occurred: %s", e)
+ logging.error("Error occurred: %s", e)

Powered by: pixeebot (codemod ID: pixee:python/lazy-logging)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pixeeai
Copy link
Author

pixeeai commented Mar 29, 2024

FYI - This change was autogenerated from a new trending GitHub app - called Pixeebot. A code-quality GitHub App; like Dependabot, but for source code.

@pixeeai
Copy link
Author

pixeeai commented Jul 28, 2024

@astonzhang @cooelf any thoughts for this change request?

@pixeeai
Copy link
Author

pixeeai commented Nov 2, 2024

Any chance you've had the time to review these changes?

If you're not interested implementing them at this time, no worries. I can close the PR and follow up with additional changes in the future. Also, this plugin is free for non-commercial open sourced projects, so feel free to give it an install if you want to see the other recommended PRs.

Thanks,
Zach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant