Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ISL model constructor method naming consistent #197

Open
desaikd opened this issue Jul 5, 2023 · 0 comments
Open

Make ISL model constructor method naming consistent #197

desaikd opened this issue Jul 5, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@desaikd
Copy link
Contributor

desaikd commented Jul 5, 2023

All the ISL model constructor methods has names as per usage. For example to construct IslConstraint::ByteLength() constraint we have a method called byte_length, this follows the pattern defined here. This differs from the naming convention we have for Range with #190 which will have new_single_value and new_inclusive (new_*) methods. all the constructor methods for ISL model should follow the same naming convention for consistent APIs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@desaikd