Fixes #963 by properly setting the cursor's checkpoint after reading tagged values in an expression group. #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popematt
approved these changes
Oct 11, 2024
tgregg
force-pushed
the
ion-11-encoding-text-evaluation-fix-962-text-rest
branch
from
344cf95
to
dde152c
Compare
Base automatically changed from
ion-11-encoding-text-evaluation-fix-962-text-rest
to
ion-11-encoding
October 14, 2024 19:51
…tagged values in an expression group.
tgregg
force-pushed
the
ion-11-encoding-text-evaluation-fix-962-text-rest-fix-963
branch
from
71f9e37
to
0c92657
Compare
tgregg
deleted the
ion-11-encoding-text-evaluation-fix-962-text-rest-fix-963
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #963
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.