Fixes a bug that caused the binary reader to stop consuming from the stream after evaluating an e-expression that produced no values. #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jobarr-amzn
approved these changes
Oct 11, 2024
popematt
approved these changes
Oct 11, 2024
Base automatically changed from
ion-11-encoding-text-evaluation
to
ion-11-encoding
October 11, 2024 22:49
…stream after evaluating an e-expression that produced no values.
tgregg
force-pushed
the
ion-11-encoding-text-evaluation-fix-962
branch
from
3cd2a82
to
05a1351
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #962
Description of changes:
The diff is smaller than it looks. The scope of the
whileloop is extended over everything inIonReaderContinuableCoreBinary.nextValue(). The reader goes around the loop again any time the end of the active e-expression evaluation is reached. Doing so allows it to properly consume the next value from the stream instead of returning while still "between" values.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.