Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds implementations of if_* special forms #957

Merged
merged 4 commits into from
Oct 5, 2024

Conversation

popematt
Copy link
Contributor

@popematt popematt commented Oct 4, 2024

Issue #, if available:

None

Description of changes:

Adds support for if_some, if_none, if_single, and if_multi to the MacroEvaluator.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@popematt popematt requested a review from tgregg October 4, 2024 06:31
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (ion-11-encoding@f9f72f0). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                 @@
##             ion-11-encoding     #957   +/-   ##
==================================================
  Coverage                   ?   70.08%           
  Complexity                 ?     6914           
==================================================
  Files                      ?      197           
  Lines                      ?    27345           
  Branches                   ?     4944           
==================================================
  Hits                       ?    19165           
  Misses                     ?     6643           
  Partials                   ?     1537           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tgregg tgregg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. These cases would really benefit from a lazy evaluator.

@popematt popematt merged commit ebb3b65 into amazon-ion:ion-11-encoding Oct 5, 2024
20 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants