Enables MacroCompiler to operate over an IonReader. #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popematt
reviewed
Sep 24, 2024
| } | ||
| private inline fun ReaderType.forEachInContainer(block: ReaderType.(IonType) -> Unit) = readContainer { forEachRemaining(block) } | ||
|
|
||
| abstract fun ReaderType.readerHasAnnotations(): Boolean |
There was a problem hiding this comment.
There's no need for these to be extension functions, and I think it may be a little more readable as non-extension functions. (I realize that I made extension functions for readContainer, forEachRemaining, etc. They are also don't need to be extension functions.) If we get rid of the receiver type on all of these functions, then we no longer need the type parameter on the class. Finally, all of these abstract methods can be protected.
tgregg
force-pushed
the
ion-11-encoding-macro-compiler-ionreader
branch
from
e4b9f5f
to
b00703f
Compare
popematt
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We will use
MacroCompilerContinuablefor binary andMacroCompilerIonReaderfor text. If there's a better way to achieve this in Kotlin, I'm open to it.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.