Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates 'each' clauses to allow alternating name-strings and fragments #911

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

popematt
Copy link
Contributor

Issue #, if available:

Implements amazon-ion/ion-tests#121

Description of changes:

Now name strings can be alternated with fragments in an each clause.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@popematt popematt requested a review from tgregg July 12, 2024 04:24
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (ion-11-encoding@f3b8148). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                 @@
##             ion-11-encoding     #911   +/-   ##
==================================================
  Coverage                   ?   69.65%           
  Complexity                 ?     6466           
==================================================
  Files                      ?      184           
  Lines                      ?    25608           
  Branches                   ?     4600           
==================================================
  Hits                       ?    17836           
  Misses                     ?     6386           
  Partials                   ?     1386           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@popematt popematt merged commit 38c675a into amazon-ion:ion-11-encoding Jul 12, 2024
20 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants