Swaps the order of the macro ID and length FlexUInts for opcode OxF5, putting ID before length. #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zslayton
approved these changes
Jun 27, 2024
popematt
approved these changes
Jun 27, 2024
tgregg
force-pushed
the
cursor-read-tagless-reorder-flexsym-incremental
branch
2 times, most recently
from
5674e82
to
c985cf4
Compare
Base automatically changed from
cursor-read-tagless-reorder-flexsym-incremental
to
ion-11-encoding
June 28, 2024 19:56
… putting ID before length.
…oInvocationHeader.
tgregg
force-pushed
the
reorder-f5-id-and-length
branch
from
3928f17
to
8746cae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Builds on #884. The spec will soon be updated to clarify that this is the correct order. Included in this PR is a separate small commit that corrects handling of the return value of the
slowReadMacroInvocationHeadermethod.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.