Adds support for reading binary tagless types. #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popematt
approved these changes
Jun 27, 2024
tgregg
force-pushed
the
read-macro-invocation-headers
branch
from
81ef1da
to
34d6211
Compare
Base automatically changed from
read-macro-invocation-headers
to
ion-11-encoding
June 28, 2024 19:39
tgregg
force-pushed
the
cursor-read-tagless-reorder
branch
from
bce90be
to
a6a6a37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
See the tagless encodings section in the binary Ion 1.1 spec.
This PR implements support for tagless types at the raw / core level. It is assumed that a higher-level reader (i.e., one capable of interpreting macro invocations) knows which tagless type to expect next and positions the core reader accordingly. Macro evaluation will be added in a future PR.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.