Improves performance by representing the LST using a Map instead of SymbolTable in IonManagedWriter_1_1. #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ymbolTable in IonManagedWriter_1_1.
popematt
approved these changes
May 14, 2024
tgregg
added a commit
that referenced
this pull request
Jun 28, 2024
…ymbolTable in IonManagedWriter_1_1. (#854)
tgregg
added a commit
that referenced
this pull request
Sep 9, 2024
…ymbolTable in IonManagedWriter_1_1. (#854)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Performance measured by https://github.com/amazon-ion/ion-java-benchmark-cli/tree/ion-1-1 using a 20MB binary Ion log file.
Before this PR:
236 ms / op
After this PR:
189 ms / op
If this can be made more Kotlin-idiomatic I'm open to it. We should also try making
newSymbolsa map if thenewSymbols.indexOflookup starts showing up in profiles.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.