Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds check for license headers and unused imports #789

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

popematt
Copy link
Contributor

@popematt popematt commented Apr 12, 2024

Issue #, if available:

None

Description of changes:

I noticed recently that some of our files are lacking a license header. I've added the spotless plugin to ensure that we have a license header on all new java and kotlin files going forward. I also included a check for unused imports in java, but that might be redundant with spotbugs. In kotlin, it's already checked by ktlint.

If you happen to forget to add license headers, you can have this tool add them automatically by running ./gradlew spotlessApply.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@popematt popematt force-pushed the master branch 2 times, most recently from d5a90fc to d396c2c Compare April 12, 2024 17:02
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.35%. Comparing base (3c1b6b1) to head (051285b).
Report is 29 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #789      +/-   ##
============================================
+ Coverage     67.23%   67.35%   +0.12%     
- Complexity     5484     5506      +22     
============================================
  Files           159      160       +1     
  Lines         23025    23067      +42     
  Branches       4126     4123       -3     
============================================
+ Hits          15481    15537      +56     
+ Misses         6262     6256       -6     
+ Partials       1282     1274       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@popematt popematt force-pushed the master branch 2 times, most recently from b1e8f6f to 65a63c4 Compare April 12, 2024 20:27
@popematt popematt merged commit eb6c877 into amazon-ion:master Apr 12, 2024
17 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants