Fix inconsistent equals and hashcode when annotations are cleared #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage is 📢 Thoughts on this report? Let us know!. |
tgregg
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
None
Description of changes:
The hashing of annotations was inconsistent with equals. When the
_annotationsarray wasnullor an empty array, thenhashTypeAnnotationswould return the original hash of the value. If_annotationswas a non-empty array, but all of it's elements were null (i.e. no annotations),hashTypeAnnotations()would returnvalueHashSalt * original.This change moves the "return if no annotations" check until after we've counted the annotations in the array to make sure that a null or 0-size array is hashed equivalently to a null-element array.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.