Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to standard layout #555

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Refactor to standard layout #555

merged 1 commit into from
Nov 16, 2023

Conversation

gliptak
Copy link
Contributor

@gliptak gliptak commented Aug 27, 2023

Issue #, if available: fixes #66

#545

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7fe1fd8) 67.01% compared to head (999ad63) 67.01%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #555   +/-   ##
=========================================
  Coverage     67.01%   67.01%           
  Complexity     5459     5459           
=========================================
  Files           159      159           
  Lines         22938    22938           
  Branches       4113     4113           
=========================================
  Hits          15372    15372           
- Misses         6288     6289    +1     
+ Partials       1278     1277    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@popematt
Copy link
Contributor

Thanks for this contribution. Right now, we have a large feature that is in-flight, and merging this right now will make merging the other feature more complicated.

We will accept this contribution, but we would like to put on hold until after #517 is merged.

@gliptak
Copy link
Contributor Author

gliptak commented Oct 18, 2023

@popematt rebased

@popematt
Copy link
Contributor

@gliptak We are releasing v1.11.0 with the large changes that were just merged. Once we have finished the release, one of us can rebase again (there's a few minor commits that will not be affected by this PR), and then merge in your change. Thank you for your patience.

Signed-off-by: Gábor Lipták <[email protected]>
@popematt
Copy link
Contributor

The failures in the performance regression workflow are not introduced by this change. I'll need to look into it more, but it's not a blocker for merging this PR.

@popematt popematt merged commit 5daea99 into amazon-ion:master Nov 16, 2023
10 of 34 checks passed
tgregg pushed a commit that referenced this pull request Jan 18, 2024
tgregg pushed a commit that referenced this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to standard Maven src/test dirs
2 participants