Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing ion struct with Map<> to store key/value fetched from extractor. #61

Open
cheqianh opened this issue Oct 22, 2021 · 0 comments

Comments

@cheqianh
Copy link
Contributor

This issue was raised in #59 (comment)

In ion-hive-serde, we are using an ion struct to store values fetched from a path extractor because of:

  1. We need a key-value store to carry column values
  2. The top-level IonStruct as a context object carries the IonSystem which we use as a ValueFactory in the callbacks created in PathExtractionConfig

 
As mentioned in above comment,

Motivation for using a non-IonValue as our top level key-value store and context object is that it intentionally disrupts handling of recursive IonValues. This shouldn't be an IonStruct- it's a collection of columns whose values are IonValues.

It would be good to replace our path extractor context object with a Map<String,IonValue> or some similar non-IonValue context object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant