Delete the page pool allocator #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadderchris
force-pushed
the
delete-page-pool
branch
from
197237c
to
6828cc0
Compare
The page pool allocator leaks memory when used in a threaded context (amazon-ion#264). While we could invest in making this thread-safe by using proper concurrency primitives, it's not clear that the page pool allocator is actually providing any benefit right now. There are no benchmarks to indicate that it is, and any sane allocator should already be doing something like this behind the scenes (in a thread-safe way to boot). This nukes the page pool code. We can perform some perf tests and benchmarks to determine if it's really worth it to reintroduce something like it in the future.
The IonBinarySymbol.ReaderReadsSymbolValueZeroAsSID test frees the reader it's using before it reads out the symbol table.
…llFidelityDecNumber
sadderchris
force-pushed
the
delete-page-pool
branch
from
1021873
to
18d9ef9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #264
Description of changes:
The page pool allocator leaks memory when used in a threaded context (#264). While we could invest in making this thread-safe by using proper concurrency primitives, it's not clear that the page pool allocator is actually providing any benefit right now.
There are no benchmarks to indicate that it is, and any sane allocator should already be doing something like this behind the scenes (or should be configurable to, in a thread-safe way to boot). I ran some (limited) benchmarks on the
ionizercli, and there wasn't a significant difference in performance without the page pool (the timings were within margin of error, a handful of microseconds at most - not noticeable on the human scale, at least forionizer's use cases).This nukes the page pool code. We can perform some more perf tests and benchmarks to determine if it's really worth it to reintroduce something like it in the future.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.