Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ion-test-driver workflow will fail whenever lines are added/removed from a file that produces expected errors. #317

Open
tgregg opened this issue Jan 23, 2023 · 0 comments

Comments

@tgregg
Copy link
Contributor

tgregg commented Jan 23, 2023

This happens because the failure message includes the line number from which the error originated. Example here. This requires developers to manually look through the test-driver results and determine that they are false positives, introducing the risk of an incorrect evaluation that results in a behavioral change being allowed through. We should consider whether the best solution is to build ion-c in release mode (instead of debug mode) in ion-test-driver, or to change the evaluation logic in ion-test-driver, or something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant