Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cocoapods integration #107

Open
danieljvdm opened this issue Sep 21, 2017 · 3 comments
Open

Cocoapods integration #107

danieljvdm opened this issue Sep 21, 2017 · 3 comments

Comments

@danieljvdm
Copy link

Could you please include a podspec so that we can use cocoapods with this library? Thanks!

@danieljvdm
Copy link
Author

It would probably look something like this:

require "json"

package = JSON.parse(File.read(File.join(__dir__, "package.json")))

Pod::Spec.new do |s|

  s.name           = "react-native-photo-view"
  s.version        = package['version'].gsub(/v|-beta/, '')
  s.summary        = package['description']
  s.author         = package['author']
  s.license        = package['license']
  s.homepage       = package['homepage']
  s.source         = { :git => 'https://github.com/alwx/react-native-photo-view.git', :tag => "v#{s.version}"}
  s.platform       = :ios, '7.0'
  s.source_files  = "ios/*.{h,m}"
  s.dependency "React"

end

@danieljvdm
Copy link
Author

As a temporary fix: #111

@JensDebergh
Copy link
Contributor

JensDebergh commented Nov 27, 2017

Temporary fix works fine for standard react-native projects but will fail if you go off the beaten path like we are doing at the company.

Adding a cocoapod file is a must in our case. Did a quick pull request and hope to get it merged:

Fix with cocoapods: #143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants