Fix yaml plugin loading on Python 3.9 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You get an error trying to run this with Python 3.9 and latest pip install: ``` $ pptop <PID> load() missing 1 required positional argument: 'Loader' ``` Since the PyYAML library [API changed](yaml/pyyaml#576), we need to use `safe_load` (which should be the default anyways).
divi255
approved these changes
Nov 19, 2021
|
thank you for reporting and providing the fix. yes, we still use "load" instead of "safe_load" in some projects as "load" allows to inject a code inside YAML directly. but for pptop this "feature" is not required anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You get an error trying to run this with Python 3.9 and latest pip
install:
Since the PyYAML library API changed,
we need to use
safe_load(which should be the default anyways).