Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up concurrency issues around Untwister object state #34

Open
altf4 opened this issue Aug 17, 2015 · 0 comments
Open

Clean up concurrency issues around Untwister object state #34

altf4 opened this issue Aug 17, 2015 · 0 comments
Labels

Comments

@altf4
Copy link
Owner

altf4 commented Aug 17, 2015

State tracking and thread dependency in the Untwister class is a bit messy. It needs some cleaning. There are three states Untwister can be in: starting, running, or finished. Importantly, these states are strictly sequential. Some issues related to this are:

  • Users of Untwister can check this state by querying one of three bools, which map to the above states. This is clumsy because it's possible for multiple or none of the bools to be set at any given time. (Due to a race condition window of time between changing states)
  • Checking state is not reliable, as the state can change the moment after you've checked it. This can be resolved by either blocking all of untwister while status is being checked (which would be horrible), or by making it clear that status is unreliable and that users of the Untwister object have to be aware of that.
@altf4 altf4 added the bug label Aug 17, 2015
@altf4 altf4 changed the title Clean up concurrency issues aroudn Untwister object state Clean up concurrency issues around Untwister object state Aug 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant