This repository has been archived by the owner on Dec 19, 2023. It is now read-only.
TT-1211: upgrading dropwizard #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the upgrade, jackson has upgraded to 2.8 They over-eagerly prevent our polymorphism (FasterXML/jackson-databind#1358) so we have to use custom deserialisers for the interfaces Solo: @hugh-emerson
hugh-emerson
force-pushed
the
TT-1211
branch
from
19b14a5
to
cf8d90f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the upgrade, jackson has upgraded to 2.8.
They over-eagerly prevent our polymorphism (FasterXML/jackson-databind#1358)
I removed the defaultImpl in the last commit but actually that would cause a lot of extra work.
I believe the best solution for now is to use custom deserialisers for the interfaces.
Tested by running msa and stubs with this change locally.
Solo: hugh-emerson