Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add component wrapper to feedback component #4351

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Add component wrapper to feedback component #4351

merged 1 commit into from
Nov 7, 2024

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Oct 30, 2024 •
edited
Loading

What

Why

As the trello card states:

Standardising our components to use the component wrapper helper will reduce code, increase standardisation, and improve future feature implementation speed.

Visual changes

None.

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4351 October 30, 2024 12:11 Inactive
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4351 October 30, 2024 12:12 Inactive
@AshGDS AshGDS marked this pull request as ready for review October 30, 2024 14:11
@AshGDS AshGDS self-assigned this Oct 30, 2024
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4351 November 7, 2024 16:31 Inactive
@AshGDS AshGDS merged commit 56e6a31 into main Nov 7, 2024
12 checks passed
@AshGDS AshGDS deleted the feedback-component-wrapper branch November 7, 2024 16:33
@KludgeKML KludgeKML mentioned this pull request Nov 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andysellick andysellick andysellick approved these changes

Assignees

@AshGDS AshGDS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AshGDS @andysellick @govuk-ci