Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate removing YouTube video from image card component #4071

Open
MartinJJones opened this issue Jun 21, 2024 · 1 comment
Open

Investigate removing YouTube video from image card component #4071

MartinJJones opened this issue Jun 21, 2024 · 1 comment
Assignees
@MartinJJones
Labels
breaking change A breaking change is present in this issue or pull request

Comments

@MartinJJones
Copy link
Contributor

What

We should look at removing YouTube video from the image-card component - https://components.publishing.service.gov.uk/component-guide/image_card#youtube_video

Why

  • This feature does not appear to be used on GOV.UK
  • Removing this feature, would also mean that we can remove image-card.js in each application currently using the image card component
@MartinJJones MartinJJones added the breaking change A breaking change is present in this issue or pull request label Sep 18, 2024
@andysellick
Copy link
Contributor

@MartinJJones I've got a feeling we should prioritise this issue. I'm happy to take it on if you're busy this week?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MartinJJones MartinJJones

Labels
breaking change A breaking change is present in this issue or pull request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andysellick @MartinJJones